Bug 162891

Summary: [SOUP] Move request HTTP body handling to ResourceRequestSoup and simplify it
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, bugs-noreply, commit-queue, danw, gustavo, mcatanzaro, mrobinson
Priority: P2 Keywords: Gtk, Soup
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Description Carlos Garcia Campos 2016-10-04 00:55:04 PDT 
We are currently adding the HTTP body to the message in ResourceHandleSoup, but we could do it as part of the ResourceRequest::updateSoupMessage() method, since the HTTP body is indeed part of the request.
Comment 1 Carlos Garcia Campos 2016-10-04 01:04:30 PDT 
Created attachment 290577 [details]
Patch
Comment 2 Alex Christensen 2016-10-04 08:06:38 PDT 
Comment on attachment 290577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290577&action=review

> Source/WebCore/platform/soup/SharedBufferSoup.cpp:43
> +    if (m_soupBuffer && !offset && !size) {

!size? Is this correct?
Comment 3 Carlos Garcia Campos 2016-10-04 08:33:31 PDT 
Comment on attachment 290577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290577&action=review

>> Source/WebCore/platform/soup/SharedBufferSoup.cpp:43
>> +    if (m_soupBuffer && !offset && !size) {
> 
> !size? Is this correct?

Yes, it means this was called with no arguments, and then we just take a return a reference.
Comment 4 Carlos Garcia Campos 2016-10-05 00:11:16 PDT 
Committed r206805: <http://trac.webkit.org/changeset/206805>