Bug 162880

Summary: Add Display P3 ColorSpace
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, ossy, ryanhaddad, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 162998    
Bug Blocks:    
Attachments:
Description Flags
Patch
sam: review+
Patch none

Description Dean Jackson 2016-10-03 15:23:30 PDT
Add Display P3 ColorSpace
Comment 1 Radar WebKit Bug Importer 2016-10-03 15:24:27 PDT
<rdar://problem/28598564>
Comment 2 Dean Jackson 2016-10-03 15:28:05 PDT
Created attachment 290528 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-10-03 15:30:51 PDT
Comment on attachment 290528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290528&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:100
> +    static CGColorSpaceRef displayP3Space = deviceRGBColorSpaceRef();

Do we really want to use device here, or fall back to sRGB?
Comment 4 Dean Jackson 2016-10-03 15:39:54 PDT
Created attachment 290529 [details]
Patch
Comment 5 Dean Jackson 2016-10-05 22:18:49 PDT
Committed r206845: <http://trac.webkit.org/changeset/206845>
Comment 6 Csaba Osztrogon√°c 2016-10-05 23:06:41 PDT
(In reply to comment #5)
> Committed r206845: <http://trac.webkit.org/changeset/206845>

It broke the El Capitan build,see build.webkit.org for details.
Comment 7 WebKit Commit Bot 2016-10-05 23:53:37 PDT
Re-opened since this is blocked by bug 162998