Bug 162873

Summary: Missing include in MediaDescription
Product: WebKit Reporter: Enrique Ocaña <eocanha>
Component: PlatformAssignee: Enrique Ocaña <eocanha>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 157314    
Attachments:
Description Flags
Patch
none
Patch none

Description Enrique Ocaña 2016-10-03 11:46:21 PDT
Build fails when MediaDesciption.h is included in a file with no other dependencies which already require the AtomicString header.
Comment 1 Enrique Ocaña 2016-10-03 11:49:14 PDT
Created attachment 290498 [details]
Patch
Comment 2 Alex Christensen 2016-10-03 14:13:19 PDT
Comment on attachment 290498 [details]
Patch

Actually, does <wtf/Forward.h> work?
Comment 3 Enrique Ocaña 2016-10-04 02:57:09 PDT
Created attachment 290585 [details]
Patch
Comment 4 Enrique Ocaña 2016-10-04 02:58:36 PDT
Yes, Forward.h works at the expense of having to include the AtomicString header in the final cpp file. It seems a good compromise.
Comment 5 Xabier Rodríguez Calvar 2016-10-04 06:35:47 PDT
Comment on attachment 290585 [details]
Patch

For this you wouldn't even need to upload the patch for review. It could be an unreviewed build fix.
Comment 6 Xabier Rodríguez Calvar 2016-10-04 06:36:34 PDT
And it is something you can land now, no need to wait for other MSE changes.
Comment 7 WebKit Commit Bot 2016-10-08 04:57:22 PDT
Comment on attachment 290585 [details]
Patch

Clearing flags on attachment: 290585

Committed r206952: <http://trac.webkit.org/changeset/206952>
Comment 8 WebKit Commit Bot 2016-10-08 04:57:26 PDT
All reviewed patches have been landed.  Closing bug.