Bug 162854

Summary: Add support for KeyboardEvent.repeat attribute
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, Brok1966, cdumez, commit-queue, crianizied40, darin, noahwater47, rniwa, samsunrock266, sam, webkit, zhaowanyi815
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://w3c.github.io/uievents/#dom-keyboardevent-repeat
Bug Depends on:    
Bug Blocks: 162852    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-10-01 20:35:59 PDT
Add support for KeyboardEvent.repeat attribute: - https://w3c.github.io/uievents/#dom-keyboardevent-repeat
Attachments
Patch (6.72 KB, patch)
2016-10-02 11:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-02 11:58:19 PDT
Created attachment 290472 [details] Patch
Darin Adler
Comment 2 2016-10-02 14:13:21 PDT
Comment on attachment 290472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290472&action=review > Source/WebCore/dom/KeyboardEvent.cpp:109 > + , m_repeat(key.isAutoRepeat()) There are no tests that cover this code path.
WebKit Commit Bot
Comment 3 2016-10-02 14:35:54 PDT
Comment on attachment 290472 [details] Patch Clearing flags on attachment: 290472 Committed r206724: <http://trac.webkit.org/changeset/206724>
WebKit Commit Bot
Comment 4 2016-10-02 14:35:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.