Bug 162838

Summary:

[ES6] GeneratorFunction constructor should instantiate generator function

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, darin, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	saam: review+

Yusuke Suzuki

Reported 2016-09-30 23:57:22 PDT

[ES6] GeneratorFunction constructor should instantiate generator function

Attachments
Patch (10.67 KB, patch) 2016-09-30 23:59 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (14.34 KB, patch) 2016-10-01 00:39 PDT, Yusuke Suzuki	saam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2016-09-30 23:59:14 PDT

Yusuke Suzuki

Comment 2 2016-10-01 00:39:16 PDT

Yusuke Suzuki

Comment 3 2016-10-01 00:39:49 PDT

OK, ready.

Saam Barati

Comment 4 2016-10-01 16:05:20 PDT

Comment on attachment 290433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290433&action=review r=me > Source/JavaScriptCore/ChangeLog:15 > + 2. Pass newTarget ins GeneratorFunction constructor to make it subclassible s/ins/into

Yusuke Suzuki

Comment 5 2016-10-01 16:36:04 PDT

Comment on attachment 290433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290433&action=review >> Source/JavaScriptCore/ChangeLog:15 >> + 2. Pass newTarget ins GeneratorFunction constructor to make it subclassible > > s/ins/into Ooops! Thanks.

Yusuke Suzuki

Comment 6 2016-10-01 16:37:46 PDT

Note You need to log in before you can comment on or make changes to this bug.