| Summary: | [MultiCol] Render tree should be all clean by the end of FrameView::layout(). | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 162834 | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2016-09-30 19:34:36 PDT
LayoutTests/fast/inline/quotation-text-changes-dynamically.html LayoutTests/fast/css/content/quote-crash-when-floating.html (In reply to comment #0) > We fail to clean all the renderers while running the following test: > LayoutTests/imported/blink/fast/multicol/dynamic/multicol-with-abspos-svg- > with-foreignobject-with-multicol-crash.html Fixed by http://trac.webkit.org/changeset/208661 Created attachment 294800 [details]
Patch
Comment on attachment 294800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294800&action=review > Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:172 > + RenderTreeInternalMutationScope reparentingIsOn(view()); Do you really want this scope to last until the end of the function? Comment on attachment 294800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294800&action=review > Source/WebCore/rendering/RenderView.h:206 > + bool renderTreeIsBeingMutatedInternally() const { return !!m_renderTreeInternalMutationCounter; } No need for !! (C++ converts non-0 to true for you). Comment on attachment 294800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294800&action=review >> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:172 >> + RenderTreeInternalMutationScope reparentingIsOn(view()); > > Do you really want this scope to last until the end of the function? I do. While spanner removal probably won't impact the RenderQuote use case, it is still part of internal render tree mutation and in the future we might need to bail out in some other functions to avoid (similar) unintended changes. Comment on attachment 294800 [details] Patch Clearing flags on attachment: 294800 Committed r208731: <http://trac.webkit.org/changeset/208731> All reviewed patches have been landed. Closing bug. |