Bug 162793

Summary: Use topVMEntryFrame to determine whether to skip the re-throw of a simulated throw.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162351    
Attachments:
Description Flags
proposed patch.
mark.lam: review-
proposed patch. saam: review+

Mark Lam
Reported 2016-09-30 10:44:34 PDT
Change the ThrowScope destructor to use topVMEntryFrame (instead of topCallFrame) in the determination of whether to skip the re-throw of a simulated throw. This is needed because the topCallFrame is not updated in operationConstructArityCheck(), whereas topVMEntryFrame is always updated properly. Hence, we should just switch to using the more reliable topVMEntryFrame instead.
Attachments
proposed patch. (2.23 KB, patch)
2016-09-30 10:48 PDT, Mark Lam 		mark.lam: review-
DetailsFormatted DiffDiff
proposed patch. (2.32 KB, patch)
2016-09-30 10:51 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-09-30 10:48:57 PDT
Created attachment 290348 [details] proposed patch.
Mark Lam
Comment 2 2016-09-30 10:49:24 PDT
Comment on attachment 290348 [details] proposed patch. Need to fix the comment.
Mark Lam
Comment 3 2016-09-30 10:51:25 PDT
Created attachment 290349 [details] proposed patch.
Saam Barati
Comment 4 2016-09-30 11:02:15 PDT
Comment on attachment 290349 [details] proposed patch. r=me
Mark Lam
Comment 5 2016-09-30 11:18:43 PDT
Thanks for the review. Landed in r206643: <http://trac.webkit.org/r206643>.
Note You need to log in before you can comment on or make changes to this bug.