Bug 162782

Summary: Implement rendering of font-variation-settings
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, mmaxfield, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162490    
Attachments:
Description Flags
Patch
none
Patch
zalan: review+
Patch for re-landing commit-queue: commit-queue-

Myles C. Maxfield
Reported 2016-09-30 03:19:20 PDT
Implement rendering of font-variation-settings
Attachments
Patch (20.45 KB, patch)
2016-09-30 03:19 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (24.69 KB, patch)
2016-09-30 15:06 PDT, Myles C. Maxfield 		zalan: review+
DetailsFormatted DiffDiff
Patch for re-landing (24.71 KB, patch)
2016-10-03 02:33 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-09-30 03:19:41 PDT
Created attachment 290318 [details] Patch
Myles C. Maxfield
Comment 2 2016-09-30 15:06:28 PDT
Created attachment 290392 [details] Patch
Myles C. Maxfield
Comment 3 2016-09-30 16:14:48 PDT
Committed r206692: <http://trac.webkit.org/changeset/206692>
Chris Dumez
Comment 4 2016-10-02 11:21:34 PDT
Reverted r206692 and r206718 for reason: Seems to have caused >200 failures on Sierra Committed r206719: <http://trac.webkit.org/changeset/206719>
Ryan Haddad
Comment 5 2016-10-02 12:29:17 PDT
(In reply to comment #4) > Reverted r206692 and r206718 for reason: > > Seems to have caused >200 failures on Sierra > > Committed r206719: <http://trac.webkit.org/changeset/206719> Example of failures: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/256
Myles C. Maxfield
Comment 6 2016-10-03 02:33:04 PDT
Created attachment 290481 [details] Patch for re-landing
WebKit Commit Bot
Comment 7 2016-10-03 14:36:42 PDT
Comment on attachment 290481 [details] Patch for re-landing Rejecting attachment 290481 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 290481, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2213220
Myles C. Maxfield
Comment 8 2016-10-03 17:08:54 PDT
Committed r206761: <http://trac.webkit.org/changeset/206761>
Radar WebKit Bug Importer
Comment 9 2017-02-10 01:48:31 PST
<rdar://problem/30461633>
Note You need to log in before you can comment on or make changes to this bug.