Bug 162778

Summary: Remove "rem" unit optimization for document element font size changes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Archive of layout-test-results from ews106 for mac-yosemite-wk2 none

Antti Koivisto
Reported 2016-09-30 03:06:36 PDT
We track from the parser level if any stylesheet in a document uses any rem units. This is only used to minimally optimize a case where document element's (<html>) font size changes dynamically. In practice such changes are rare.
Attachments
patch (8.88 KB, patch)
2016-09-30 03:16 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.31 MB, application/zip)
2016-09-30 04:14 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-09-30 03:16:34 PDT
Created attachment 290316 [details] patch
Build Bot
Comment 2 2016-09-30 04:14:07 PDT
Comment on attachment 290316 [details] patch Attachment 290316 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2174390 New failing tests: fast/images/pixel-crack-image-background-webkit-transform-scale.html
Build Bot
Comment 3 2016-09-30 04:14:10 PDT
Created attachment 290324 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
WebKit Commit Bot
Comment 4 2016-09-30 10:02:45 PDT
Comment on attachment 290316 [details] patch Clearing flags on attachment: 290316 Committed r206641: <http://trac.webkit.org/changeset/206641>
WebKit Commit Bot
Comment 5 2016-09-30 10:02:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.