Bug 162765

Summary: Add support for download attribute on area elements
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, darin, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 156056    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2
none
Patch none

Chris Dumez
Reported 2016-09-29 18:59:49 PDT
Add support for download attribute on area elements: - https://html.spec.whatwg.org/#htmlanchorelement
Attachments
Patch (23.40 KB, patch)
2016-09-29 19:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (25.48 KB, patch)
2016-09-29 19:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 (6.79 MB, application/zip)
2016-09-29 20:52 PDT, Build Bot 		no flags
Details
Patch (38.02 KB, patch)
2016-09-29 21:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-09-29 19:35:54 PDT
Created attachment 290284 [details] Patch
Chris Dumez
Comment 2 2016-09-29 19:41:51 PDT
Created attachment 290285 [details] Patch
Build Bot
Comment 3 2016-09-29 20:52:17 PDT
Comment on attachment 290285 [details] Patch Attachment 290285 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2172296 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Build Bot
Comment 4 2016-09-29 20:52:22 PDT
Created attachment 290288 [details] Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.6
Chris Dumez
Comment 5 2016-09-29 21:06:30 PDT
Created attachment 290290 [details] Patch
Brent Fulgham
Comment 6 2016-09-29 21:12:53 PDT
Comment on attachment 290290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290290&action=review Excellent! Thank you for adding this support. > LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:2273 > +PASS HTMLAreaElement interface: attribute download Look at all of these new PASSes! :-)
WebKit Commit Bot
Comment 7 2016-09-29 22:07:58 PDT
Comment on attachment 290290 [details] Patch Clearing flags on attachment: 290290 Committed r206630: <http://trac.webkit.org/changeset/206630>
WebKit Commit Bot
Comment 8 2016-09-29 22:08:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.