Bug 162765 - Add support for download attribute on area elements
Summary: Add support for download attribute on area elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks: 156056
  Show dependency treegraph
 
Reported: 2016-09-29 18:59 PDT by Chris Dumez
Modified: 2016-09-29 22:08 PDT (History)
10 users (show)

See Also:


Attachments
Patch (23.40 KB, patch)
2016-09-29 19:35 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (25.48 KB, patch)
2016-09-29 19:41 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 (6.79 MB, application/zip)
2016-09-29 20:52 PDT, Build Bot
no flags Details
Patch (38.02 KB, patch)
2016-09-29 21:06 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-29 18:59:49 PDT
Add support for download attribute on area elements:
- https://html.spec.whatwg.org/#htmlanchorelement
Comment 1 Chris Dumez 2016-09-29 19:35:54 PDT
Created attachment 290284 [details]
Patch
Comment 2 Chris Dumez 2016-09-29 19:41:51 PDT
Created attachment 290285 [details]
Patch
Comment 3 Build Bot 2016-09-29 20:52:17 PDT
Comment on attachment 290285 [details]
Patch

Attachment 290285 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2172296

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 4 Build Bot 2016-09-29 20:52:22 PDT
Created attachment 290288 [details]
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Chris Dumez 2016-09-29 21:06:30 PDT
Created attachment 290290 [details]
Patch
Comment 6 Brent Fulgham 2016-09-29 21:12:53 PDT
Comment on attachment 290290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290290&action=review

Excellent! Thank you for adding this support.

> LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:2273
> +PASS HTMLAreaElement interface: attribute download 

Look at all of these new PASSes! :-)
Comment 7 WebKit Commit Bot 2016-09-29 22:07:58 PDT
Comment on attachment 290290 [details]
Patch

Clearing flags on attachment: 290290

Committed r206630: <http://trac.webkit.org/changeset/206630>
Comment 8 WebKit Commit Bot 2016-09-29 22:08:04 PDT
All reviewed patches have been landed.  Closing bug.