| Summary: | parser-syntax-check should display the output of syntax errors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, jfbastien, joepeck, keith_miller, mark.lam, msaboff, oliver, ticaiolima, ysuzuki | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2016-09-29 10:53:53 PDT
Created attachment 290223 [details]
patch
Comment on attachment 290223 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=290223&action=review r=me! > LayoutTests/js/parser-syntax-check-expected.txt:92 > +PASS Invalid: "function f() { a ? b }". Produced the following syntax error: "SyntaxError: Unexpected token '}'. Expected ':' in ternary operator." Some, like this one and others, end in a period and many others don't. A good follow-up would make them all consistent. (In reply to comment #2) > Comment on attachment 290223 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290223&action=review > > r=me! > > > LayoutTests/js/parser-syntax-check-expected.txt:92 > > +PASS Invalid: "function f() { a ? b }". Produced the following syntax error: "SyntaxError: Unexpected token '}'. Expected ':' in ternary operator." > > Some, like this one and others, end in a period and many others don't. A > good follow-up would make them all consistent. Indeed. Opened: https://bugs.webkit.org/show_bug.cgi?id=162742 landed in: https://trac.webkit.org/changeset/206594 |