Bug 162738

Summary: parser-syntax-check should display the output of syntax errors
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, jfbastien, joepeck, keith_miller, mark.lam, msaboff, oliver, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch joepeck: review+

Saam Barati
Reported 2016-09-29 10:53:53 PDT
...
Attachments
patch (197.56 KB, patch)
2016-09-29 11:28 PDT, Saam Barati 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-09-29 11:28:51 PDT
Created attachment 290223 [details] patch
Joseph Pecoraro
Comment 2 2016-09-29 11:33:47 PDT
Comment on attachment 290223 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=290223&action=review r=me! > LayoutTests/js/parser-syntax-check-expected.txt:92 > +PASS Invalid: "function f() { a ? b }". Produced the following syntax error: "SyntaxError: Unexpected token '}'. Expected ':' in ternary operator." Some, like this one and others, end in a period and many others don't. A good follow-up would make them all consistent.
Saam Barati
Comment 3 2016-09-29 11:45:06 PDT
(In reply to comment #2) > Comment on attachment 290223 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290223&action=review > > r=me! > > > LayoutTests/js/parser-syntax-check-expected.txt:92 > > +PASS Invalid: "function f() { a ? b }". Produced the following syntax error: "SyntaxError: Unexpected token '}'. Expected ':' in ternary operator." > > Some, like this one and others, end in a period and many others don't. A > good follow-up would make them all consistent. Indeed. Opened: https://bugs.webkit.org/show_bug.cgi?id=162742
Saam Barati
Comment 4 2016-09-29 11:47:43 PDT
landed in: https://trac.webkit.org/changeset/206594
Note You need to log in before you can comment on or make changes to this bug.