Bug 162731

Summary: Remove addSubresourceStyleURLs functions
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
rniwa: review+, buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-yosemite-wk2 none

Antti Koivisto
Reported 2016-09-29 09:52:47 PDT
They can be replaced with calls to the modern traverseSubresources functions.
Attachments
patch (16.59 KB, patch)
2016-09-29 10:06 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (16.63 KB, patch)
2016-09-29 10:22 PDT, Antti Koivisto 		rniwa: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (939.25 KB, application/zip)
2016-09-29 11:36 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-09-29 10:06:12 PDT
Created attachment 290210 [details] patch
WebKit Commit Bot
Comment 2 2016-09-29 10:08:46 PDT
Attachment 290210 [details] did not pass style-queue: ERROR: Source/WebCore/dom/StyledElement.cpp:27: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2016-09-29 10:22:01 PDT
Created attachment 290214 [details] patch
Build Bot
Comment 4 2016-09-29 11:36:51 PDT
Comment on attachment 290214 [details] patch Attachment 290214 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2169557 New failing tests: fast/images/pdf-as-image-with-annotations.html
Build Bot
Comment 5 2016-09-29 11:36:54 PDT
Created attachment 290224 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Antti Koivisto
Comment 6 2016-09-29 12:39:42 PDT
https://trac.webkit.org/r206603
Note You need to log in before you can comment on or make changes to this bug.