Bug 162719

Summary: [GTK] Upgrade HarfBuzz to version 1.3.3
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: WebKitGTKAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, behdad, bugs-noreply, cgarcia, commit-queue, dr.khaled.hosny, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 164022    
Bug Blocks: 162671    
Attachments:
Description Flags
Patch none

Frédéric Wang (:fredw)
Reported 2016-09-29 01:02:48 PDT
The next version of HarfBuzz will contain a new API to access data from the OpenType MATH table. When it is released, we should update Tools/gtk/jhbuild.modules to use that version, so that the MathML code can rely on that new API (bug 162671).
Attachments
Patch (1.54 KB, patch)
2016-10-26 08:42 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-10-10 23:40:19 PDT
OpenType MATH support will be in version 1.3.3 https://github.com/behdad/harfbuzz/commit/d1c62370a0c2bdb365a1468dc8d782b9a7245946
Frédéric Wang (:fredw)
Comment 2 2016-10-26 08:42:38 PDT
Created attachment 292930 [details] Patch
Michael Catanzaro
Comment 3 2016-10-26 10:17:54 PDT
Comment on attachment 292930 [details] Patch OK if and only if you're ready to check the release bots when this lands, and update test expectations to get the failure rate to be the same as it was before this landed. Otherwise this will have to wait until we can get the release bot green, as I don't want to add extra layout test failures now.
Carlos Garcia Campos
Comment 4 2016-10-26 22:33:10 PDT
Now it's impossible to check the bots because of bug #164022, so please wait until the release bot is no longer exiting early before landing this.
Michael Catanzaro
Comment 5 2016-10-28 11:26:23 PDT
(In reply to comment #4) > Now it's impossible to check the bots because of bug #164022, so please wait > until the release bot is no longer exiting early before landing this. This is fixed, you can go ahead if you want. Let me know if you have questions about how to do the gardening that will be required after this lands.
WebKit Commit Bot
Comment 6 2016-10-28 12:01:15 PDT
Comment on attachment 292930 [details] Patch Clearing flags on attachment: 292930 Committed r208061: <http://trac.webkit.org/changeset/208061>
WebKit Commit Bot
Comment 7 2016-10-28 12:01:19 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 8 2016-10-28 13:40:06 PDT
Seems it caused no or almost no new failures, yay!
Note You need to log in before you can comment on or make changes to this bug.