Bug 16268
Summary: | target="_top" in embedded SVG fails to replace parent content | ||
---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | abarth, japhet, rwlbuis, timur.mehrvarz |
Priority: | P2 | Keywords: | NeedsReduction |
Version: | 523.x (Safari 3) | ||
Hardware: | Mac | ||
OS: | OS X 10.4 | ||
URL: | http://www.w3.org/2004/CDF/TestSuite/WICD_CDR_WP1/test-scalable-icon2.xhtml | ||
Bug Depends on: | |||
Bug Blocks: | 15836 |
Eric Seidel (no email)
target="_top" in embedded SVG fails to replace parent content
I'm not sure if this is an SVG issue or a more general link/object issue.
http://www.w3.org/2004/CDF/TestSuite/WICD_CDR_WP1/wicdmatrix.xhtml?implemented2
Shows how the test authors expected target="_top" to work.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
This seems to be an IE thing:
http://msdn2.microsoft.com/en-us/library/ms534659.aspx
Eric Seidel (no email)
Frame* FrameTree::find(const AtomicString& name) const
seems to correctly check for _top however.
Eric Seidel (no email)
Ok. Our problem here is in SVGAElement::defaultEventHandler:
String target = getAttribute(SVGNames::targetAttr);
String xlinktarget = getAttribute(XLinkNames::showAttr);
if (e && e->button() == MiddleButton)
target = "_blank";
else if (target.isEmpty()) // if target is empty, default to "_self" or use xlink:target if set
target = (xlinktarget == "new") ? "_blank" : "_self";
That might be the correct behavior for xlink:show, but that's not right for :target, which should behave like html's :target attribute and correctly support _top, etc.
Eric Seidel (no email)
This will be really easy to fix if we just make a test of all the various xlink:show, xlink:target and null:target values.
Rob Buis
The target="_top" part of this test seems to work fine these days.
Eric Seidel (no email)
Yes, I would be shocked if this didn't work today.