Bug 162668
| Summary: | WOFF2 test woff2-totalsfntsize fails | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
| Component: | Text | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | annulen, ben_schwartz, bfulgham, dr.khaled.hosny, mcatanzaro, mmaxfield, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://test.csswg.org/harness/test/woff2_dev/single/header-totalsfntsize-001/ | ||
| See Also: | https://bugzilla.mozilla.org/show_bug.cgi?id=1305944 | ||
| Bug Depends on: | 162608 | ||
| Bug Blocks: | |||
Frédéric Wang (:fredw)
This is handled in bug 162608 for ports using the WOFF2 copy bundled in WebKit, but other ports must ensure that a recent version of WOFF2 is used.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang (:fredw)
The port with a test expectations are Mac, iOS and Win:
fred@igalia-fwang:~/webkit/WebKit/LayoutTests$ find -type f -name TestExpectations | xargs grep woff2-totalsfntsize
./platform/mac/TestExpectations:webkit.org/b/162668 fast/text/woff2-totalsfntsize.html [ ImageOnlyFailure ]
./platform/win/TestExpectations:webkit.org/b/162668 fast/text/woff2-totalsfntsize.html [ Skip ]
./platform/ios/TestExpectations:webkit.org/b/162668 fast/text/woff2-totalsfntsize.html [ Skip ]
Myles C. Maxfield
We have fast/text/resources/ahem.woff2, does this font work instead?
Frédéric Wang (:fredw)
(In reply to Myles C. Maxfield from comment #2)
> We have fast/text/resources/ahem.woff2, does this font work instead?
Mmh, I'm not sure I understand your suggestion. The purpose of this test is to check
https://www.w3.org/TR/WOFF2/#conform-mustNotRejectIncorrectTotalSize
so we need a specific font to verify the conformance, right?
BTW I think the test is actually http://www.w3c-test.org/css/WOFF2/header-totalsfntsize-001.xht ; so maybe we can remove the current files and import https://github.com/w3c/web-platform-tests/blob/master/css/WOFF2/header-totalsfntsize-001.xht instead.
Myles C. Maxfield
Oh, whoops, please disregard my comment. Sorry for the noise.
Frédéric Wang (:fredw)
OK. Tomorrow I'll open a separate bug to import https://github.com/w3c/web-platform-tests/tree/master/css/WOFF2 anyway, as it seems we don't have them yet.
Radar WebKit Bug Importer
<rdar://problem/125586567>
Ben Schwartz
The expectations for Mac and iOS are outdated. Removing.
EWS
Test gardening commit 276814@main (93124ab0fb4c): <https://commits.webkit.org/276814@main>
Reviewed commits have been landed. Closing PR #26592 and removing active labels.