Bug 162658

Summary: Adopt MediaRemote SPI to achieve desired Now Playing behavior
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebased on ToT
none
Fix TestWebKitAPI build on iOS and public SDKs.
none
Patch for landing
none
Patch for landing wenson_hsieh: commit-queue+

Wenson Hsieh
Reported 2016-09-27 20:06:05 PDT
Adopt MediaRemote SPI to achieve desired Now Playing behavior
Attachments
Patch (42.41 KB, patch)
2016-09-27 20:14 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebased on ToT (37.18 KB, patch)
2016-09-27 20:18 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix TestWebKitAPI build on iOS and public SDKs. (35.48 KB, patch)
2016-09-27 20:49 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (38.66 KB, patch)
2016-09-28 10:21 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (36.00 KB, patch)
2016-09-28 10:27 PDT, Wenson Hsieh 		wenson_hsieh: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2016-09-27 20:06:37 PDT
<rdar://problem/28499358>
Wenson Hsieh
Comment 2 2016-09-27 20:14:59 PDT
Created attachment 290053 [details] Patch
Wenson Hsieh
Comment 3 2016-09-27 20:18:52 PDT
Created attachment 290054 [details] Rebased on ToT
Wenson Hsieh
Comment 4 2016-09-27 20:21:22 PDT
Comment on attachment 290054 [details] Rebased on ToT View in context: https://bugs.webkit.org/attachment.cgi?id=290054&action=review > Source/WebCore/ChangeLog:27 > +2016-09-27 Wenson Hsieh <wenson_hsieh@apple.com> This ChangeLog entry is from an earlier entry and was erroneously included in this patch. I will remove this.
Wenson Hsieh
Comment 5 2016-09-27 20:49:50 PDT
Created attachment 290055 [details] Fix TestWebKitAPI build on iOS and public SDKs.
Jer Noble
Comment 6 2016-09-28 09:32:29 PDT
Comment on attachment 290055 [details] Fix TestWebKitAPI build on iOS and public SDKs. View in context: https://bugs.webkit.org/attachment.cgi?id=290055&action=review r=me, with nits. > Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:133 > + MRMediaRemoteSetNowPlayingVisibility(MRMediaRemoteGetLocalOrigin(), 3 /* MRNowPlayingClientVisibilityNeverVisible */); These enums should be added to MediaRemoteSPI.h. > Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:154 > + MRMediaRemoteSetNowPlayingVisibility(MRMediaRemoteGetLocalOrigin(), 1 /* MRNowPlayingClientVisibilityAlwaysVisible */); Ditto.
Wenson Hsieh
Comment 7 2016-09-28 10:21:01 PDT
Created attachment 290098 [details] Patch for landing
WebKit Commit Bot
Comment 8 2016-09-28 10:23:19 PDT
Comment on attachment 290098 [details] Patch for landing Rejecting attachment 290098 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 290098, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2162576
Wenson Hsieh
Comment 9 2016-09-28 10:27:05 PDT
Created attachment 290099 [details] Patch for landing
Wenson Hsieh
Comment 10 2016-09-28 11:20:13 PDT
Committed r206527: <http://trac.webkit.org/changeset/206527>
Wenson Hsieh
Comment 11 2016-09-28 11:24:23 PDT
The layout test failure from commit queue does not seem related.
Note You need to log in before you can comment on or make changes to this bug.