Bug 162649

Summary: NetworkLoad and PingLoad should use private inheritance
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit2Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, beidson
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Daniel Bates 2016-09-27 17:40:48 PDT 
It is sufficient to have NetworkLoad and PingLoad privately inherit from ResourceHandleClient. Currently they publicly inherit from ResourceHandleClient.
Comment 1 Daniel Bates 2016-09-27 17:42:21 PDT 
(In reply to comment #0)
> It is sufficient to have NetworkLoad and PingLoad privately inherit from
> ResourceHandleClient.

This should read:

It is sufficient to have NetworkLoad and PingLoad privately inherit from ResourceHandleClient and NetworkDataTaskClient, respectively.
Comment 2 Daniel Bates 2016-09-27 17:57:14 PDT 
Created attachment 290039 [details]
Patch
Comment 3 Daniel Bates 2016-09-27 18:03:50 PDT 
Comment on attachment 290039 [details]
Patch

Clearing flags on attachment: 290039

Committed r206479: <http://trac.webkit.org/changeset/206479>
Comment 4 Daniel Bates 2016-09-27 18:03:54 PDT 
All reviewed patches have been landed.  Closing bug.