Bug 162633

Summary: Update style guide for #pragma once
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit WebsiteAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, joepeck, jond, mitz, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-09-27 14:16:28 PDT
Update style guide for #pragma once
Attachments
[PATCH] Proposed Fix (2.42 KB, patch)
2016-09-27 14:17 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (2.42 KB, patch)
2016-09-27 16:22 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-09-27 14:17:43 PDT
Created attachment 290006 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2016-09-27 14:18:42 PDT
As discussed on webkit-dev: https://lists.webkit.org/pipermail/webkit-dev/2016-March/thread.html#28058
mitz
Comment 3 2016-09-27 16:10:10 PDT
Comment on attachment 290006 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=290006&action=review > Websites/webkit.org/code-style.md:698 > +[](#names-header-guards) Use `#pragma once` instead of `#define` and `#ifdef` for header guards. Should the anchor name change to something else? Does the style-checking script reference this anchor?
Joseph Pecoraro
Comment 4 2016-09-27 16:19:43 PDT
Comment on attachment 290006 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=290006&action=review >> Websites/webkit.org/code-style.md:698 >> +[](#names-header-guards) Use `#pragma once` instead of `#define` and `#ifdef` for header guards. > > Should the anchor name change to something else? Does the style-checking script reference this anchor? We can change this, there are no references in WebKit to this anchor.
Joseph Pecoraro
Comment 5 2016-09-27 16:22:52 PDT
Created attachment 290019 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 6 2016-09-27 21:37:48 PDT
Comment on attachment 290019 [details] [PATCH] Proposed Fix Clearing flags on attachment: 290019 Committed r206495: <http://trac.webkit.org/changeset/206495>
WebKit Commit Bot
Comment 7 2016-09-27 21:37:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.