Bug 162621

Summary: Related videos on YouTube (and YouTube playlists) cause media controls to disappear
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Wenson Hsieh
Reported 2016-09-27 09:41:35 PDT
Related videos on YouTube (and YouTube playlists) cause media controls to disappear
Attachments
Patch (7.02 KB, patch)
2016-09-27 09:55 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.82 KB, patch)
2016-09-27 12:09 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2016-09-27 09:42:05 PDT
<rdar://problem/28484193>
Wenson Hsieh
Comment 2 2016-09-27 09:55:13 PDT
Created attachment 289960 [details] Patch
Jer Noble
Comment 3 2016-09-27 10:28:18 PDT
Comment on attachment 289960 [details] Patch Just an observation: the heuristics for now playing and the controls manager are diverging enough that we should consider splitting them up (rather than leaving them both in MediaElementSession::canShowControlsManager().
Wenson Hsieh
Comment 4 2016-09-27 10:57:36 PDT
(In reply to comment #3) > Comment on attachment 289960 [details] > Patch > > Just an observation: the heuristics for now playing and the controls manager > are diverging enough that we should consider splitting them up (rather than > leaving them both in MediaElementSession::canShowControlsManager(). I agree! We should have a canShowNowPlaying() that we can consult. I think currently the two codepaths are in an awkward state where about half of the checks are still common to both purposes, but I think splitting them out will give us more flexibility in the future, and we should refactor this soon.
Wenson Hsieh
Comment 5 2016-09-27 12:09:22 PDT
Created attachment 289994 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-09-27 12:42:05 PDT
Comment on attachment 289994 [details] Patch for landing Clearing flags on attachment: 289994 Committed r206454: <http://trac.webkit.org/changeset/206454>
WebKit Commit Bot
Comment 7 2016-09-27 12:42:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.