Bug 162614

Summary: [GTK] Simplify platformForUAString
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 142074    
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2016-09-27 08:30:11 PDT 
It's not possible to build WebKitGTK+ on Windows, this code is all dead. Not looking likely that this will change anytime soon. It's slightly broken currently (the UA includes two semicolons in a row). This code can always be restored later if adding Windows support.
Comment 1 Michael Catanzaro 2016-09-27 08:52:59 PDT 
Also DirectFB is silly. And we have to claim to be X11 no matter what, as websites expect it. The only time we should risk not including X11 is when running on a Mac, and I'm not even sure about that.
Comment 2 Michael Catanzaro 2016-09-27 08:55:16 PDT 
Created attachment 289948 [details]
Patch
Comment 3 WebKit Commit Bot 2016-09-28 05:57:12 PDT 
Comment on attachment 289948 [details]
Patch

Clearing flags on attachment: 289948

Committed r206513: <http://trac.webkit.org/changeset/206513>
Comment 4 WebKit Commit Bot 2016-09-28 05:57:15 PDT 
All reviewed patches have been landed.  Closing bug.