| Summary: | [GTK] Improve comment in platformVersionForUAString | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bugs-noreply, commit-queue, mcatanzaro | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 142074, 162610 | ||||||||
| Attachments: |
|
||||||||
|
Description
Michael Catanzaro
2016-09-27 08:21:16 PDT
Um, let's add an OS X FIXME only, since we don't support Windows. And remove the existing comment here, since it hasn't been true for a long time. Created attachment 289951 [details]
Patch
Comment on attachment 289951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289951&action=review > Source/WebCore/platform/gtk/UserAgentGtk.cpp:108 > - // We will always claim to be Safari in Mac OS X, since Safari in Linux triggers the iOS path on some websites. > + // FIXME: The final result should include OS version, e.g. "Intel Mac OS X 10_8_4". I don't understand the relationship between the comment removed and the FIXME added. The previous comment tried to explain why we include Mac OS X unconditionally, there's nothing to fix here. There is something to fix, because we don't include Mac OS X unconditionally. We need the OS X quirk. Probably adding the new comment should have be done in bug #162612. Let's handle this in that bug to avoid conflicts. Sorry, I got confused, this is a different place, separate issue. I still want to commit this patch. * The old comment is wrong. * The new comment is a FIXME that belongs in the same place. I could split it into two patches if you really want, but seems like wasted effort. (In reply to comment #5) > Sorry, I got confused, this is a different place, separate issue. I still > want to commit this patch. > > * The old comment is wrong. No, I got really confused, the comment is right, sorry. I will just add the new one. Well, it's wrong in that that code will never be executed on Linux; I'll tweak it a bit. Created attachment 290077 [details]
Patch
Ping reviewers Comment on attachment 290077 [details] Patch Rejecting attachment 290077 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 290077, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: " exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/gtk/UserAgentGtk.cpp Hunk #1 FAILED at 105. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/gtk/UserAgentGtk.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Garcia Campos']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2223501 Committed r206825: <http://trac.webkit.org/changeset/206825> |