Bug 162610

Summary: [GTK] User agent should always claim to be Intel
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Bug Depends on: 162612, 162613    
Bug Blocks: 142074    
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2016-09-27 08:17:50 PDT
We should always claim to be running on Intel regardless of actual CPU type. See discussion in bug #162548 for details. In particular, we can never advertise ARM because it causes dumb websites to send mobile pages.
Attachments
Patch (2.50 KB, patch)
2016-09-27 08:43 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2016-09-28 05:59 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-09-27 08:43:25 PDT
Created attachment 289946 [details] Patch
Carlos Garcia Campos
Comment 2 2016-09-28 03:46:08 PDT
Comment on attachment 289946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289946&action=review > Source/WebCore/platform/gtk/UserAgentGtk.cpp:96 > - static NeverDestroyed<const String> uaOSVersion(String::format("%s Mac OS X", cpuDescriptionForUAString())); > + static NeverDestroyed<const String> uaOSVersion(ASCIILiteral("Intel Mac OS X")); So, we should update the comment to also explain why we use Intel unconditionally. > Source/WebCore/platform/gtk/UserAgentGtk.cpp:121 > + uaString.appendLiteral("Intel"); > uaString.appendLiteral(" Mac OS X"); These could be a single appendLiteral call now.
Michael Catanzaro
Comment 3 2016-09-28 05:59:32 PDT
Created attachment 290080 [details] Patch
WebKit Commit Bot
Comment 4 2016-09-28 07:51:35 PDT
Comment on attachment 290080 [details] Patch Clearing flags on attachment: 290080 Committed r206517: <http://trac.webkit.org/changeset/206517>
WebKit Commit Bot
Comment 5 2016-09-28 07:51:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.