| Summary: | [cmake] Added COMPILER_IS_GCC_OR_CLANG variable to simplify conditions. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Konstantin Tokarev <annulen> | ||||
| Component: | Tools / Tests | Assignee: | Konstantin Tokarev <annulen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, lforschler, mcatanzaro, ossy | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 289934 [details]
Patch
Comment on attachment 289934 [details] Patch Clearing flags on attachment: 289934 Committed r206430: <http://trac.webkit.org/changeset/206430> All reviewed patches have been landed. Closing bug. |
Added COMPILER_IS_GCC_OR_CLANG variable to be used instead of (CMAKE_COMPILER_IS_GNUCXX OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") BTW, Clang detection will break when upgrading to CMake 3.0 as CMAKE_CXX_COMPILER_ID will become AppleClang for Clang supplied by Apple. This will be addressed in the following patch.