Bug 162605

Summary: [cmake] Added COMPILER_IS_GCC_OR_CLANG variable to simplify conditions.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2016-09-27 04:49:59 PDT
Added COMPILER_IS_GCC_OR_CLANG variable to be used instead of (CMAKE_COMPILER_IS_GNUCXX OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") BTW, Clang detection will break when upgrading to CMake 3.0 as CMAKE_CXX_COMPILER_ID will become AppleClang for Clang supplied by Apple. This will be addressed in the following patch.
Attachments
Patch (2.93 KB, patch)
2016-09-27 04:51 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-09-27 04:51:23 PDT
Created attachment 289934 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-27 05:34:18 PDT
Comment on attachment 289934 [details] Patch Clearing flags on attachment: 289934 Committed r206430: <http://trac.webkit.org/changeset/206430>
WebKit Commit Bot
Comment 3 2016-09-27 05:34:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.