Bug 162594

Summary: Extend perf dashboard to support multiple pages.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dewei_zhu, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

dewei_zhu
Reported 2016-09-26 22:26:27 PDT
Extend perf dashboard to support multiple pages.
Attachments
Patch (5.72 KB, patch)
2016-09-26 22:28 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.81 KB, patch)
2016-09-27 14:24 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2016-09-26 22:28:09 PDT
Created attachment 289916 [details] Patch
Ryosuke Niwa
Comment 2 2016-09-26 22:33:34 PDT
Comment on attachment 289916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289916&action=review > Websites/perf.webkit.org/public/v3/main.js:60 > else if (dashboardPages) There is a bug here. We should be checking dashboardPages.length here as well. > Websites/perf.webkit.org/public/v3/pages/summary-page.js:30 > - routeName() { return 'summary'; } > + routeName() { return this._route; } We should use `summary/${this._name}` instead just like we do in DashboardPage.
dewei_zhu
Comment 3 2016-09-27 14:24:50 PDT
Created attachment 290007 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-09-27 14:56:59 PDT
Comment on attachment 290007 [details] Patch for landing Clearing flags on attachment: 290007 Committed r206465: <http://trac.webkit.org/changeset/206465>
WebKit Commit Bot
Comment 5 2016-09-27 14:57:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.