Summary: | Inspector should display CDATA section data | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, joepeck, pfeldman, timothy, yurys | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | http://www.w3.org/2004/CDF/TestSuite/WICD_CDR_WP1/index.xhtml | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2007-12-02 13:03:56 PST
Created attachment 62580 [details]
[PATCH] Suggested solution
Once this issue is fixed, users are sure to hit https://bugs.webkit.org/show_bug.cgi?id=35284 when examining CDATA sections (especially long ones) in the DOM tree. This is fine, since Web Inspector just reports what it gets from the lower levels (the XML parser in this case). Comment on attachment 62580 [details]
[PATCH] Suggested solution
LGTM. I'm not an inspector expert. Let me know if you'd rather I didn't review patches like this in the future.
Comment on attachment 62580 [details]
[PATCH] Suggested solution
Please test that editing is working - we are checking both for node type and style class in the context menu editing code. Also, could you update elements panel test to include new node type?
Created attachment 62808 [details]
[PATCH] Comments addressed
Test augmented and rebaselined. Adding editing caps is non-trivial as it requires the modification of the DOM tree building procedure and doesn't seem to pay off, especially given the XML parsing bug in place.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/elements-panel-xhtml-structure-expected.txt M LayoutTests/inspector/elements-panel-xhtml-structure.xhtml M WebCore/ChangeLog M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/front-end/ElementsTreeOutline.js Committed r64267 |