Bug 162568

Summary: [WK2] BlobDownloadClient should use asynchronous IPC to decide destination path
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, beidson, bfulgham, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162543    
Attachments:
Description Flags
WIP patch
none
WIP patch
none
Patch none

Description Chris Dumez 2016-09-26 10:41:47 PDT
BlobDownloadClient should use asynchronous IPC to decide destination path. It currently uses a synchronous IPC to do so which leads to flakiness such as Bug 162543.
Comment 1 Chris Dumez 2016-09-26 13:16:43 PDT
Created attachment 289854 [details]
WIP patch
Comment 2 Chris Dumez 2016-09-26 13:38:21 PDT
Created attachment 289862 [details]
WIP patch
Comment 3 Chris Dumez 2016-09-26 14:19:13 PDT
Created attachment 289866 [details]
Patch
Comment 4 Alex Christensen 2016-09-26 14:35:11 PDT
Comment on attachment 289866 [details]
Patch

We really need a BlobDataTask and have it and NetworkDataTask inherit from a common interface.
Comment 5 Chris Dumez 2016-09-26 15:22:47 PDT
Comment on attachment 289866 [details]
Patch

Clearing flags on attachment: 289866

Committed r206397: <http://trac.webkit.org/changeset/206397>
Comment 6 Chris Dumez 2016-09-26 15:22:54 PDT
All reviewed patches have been landed.  Closing bug.