Bug 162550

Summary: [Win][Debug] Compile fix.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2016-09-26 01:27:18 PDT 
WebCore::SimpleLineLayout::FragmentForwardIterator is missing the == operator:

1>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\xutility(947): error C2678: binary '==': no operator found which takes a left-hand operand of type 'WebCore::SimpleLineLayout::FragmentForwardIterator' (or there is no acceptable conversion)
Comment 1 Per Arne Vollan 2016-09-26 02:10:55 PDT 
The '==' operator is needed in debug mode.

From xutility: 

// TEMPLATE FUNCTION _Debug_range
template<class _InIt> inline
void _Debug_range2(_InIt _First, _InIt _Last,
_Dbfile_t, _Dbline_t, input_iterator_tag)
{	// test iterator pair for valid range, arbitrary iterators
    static_cast<void>(_First == _Last);	// make sure they're comparable
}
Comment 2 Per Arne Vollan 2016-09-26 02:27:23 PDT 
Created attachment 289812 [details]
Patch
Comment 3 Per Arne Vollan 2016-09-26 02:33:08 PDT 
rdar://problem/28448683
Comment 4 Per Arne Vollan 2016-09-26 02:35:44 PDT 
Created attachment 289813 [details]
Patch
Comment 5 WebKit Commit Bot 2016-09-26 08:25:38 PDT 
Comment on attachment 289813 [details]
Patch

Clearing flags on attachment: 289813

Committed r206375: <http://trac.webkit.org/changeset/206375>
Comment 6 WebKit Commit Bot 2016-09-26 08:25:43 PDT 
All reviewed patches have been landed.  Closing bug.