Bug 162516

Summary: Refactor URLParser
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review+

Alex Christensen
Reported 2016-09-23 15:19:02 PDT
Refactor URLParser
Attachments
Patch (32.36 KB, patch)
2016-09-23 15:21 PDT, Alex Christensen 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-09-23 15:21:34 PDT
Created attachment 289714 [details] Patch
Brady Eidson
Comment 2 2016-09-23 15:26:14 PDT
Comment on attachment 289714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289714&action=review > Source/WebCore/platform/URLParser.cpp:432 > - return *iterator == ':' || *iterator == '|'; > + if (*iterator == ':') > + return true; > + if (*iterator == '|') > + return true; > + return false; Why this change? Was fine the old way.
Alex Christensen
Comment 3 2016-09-23 15:33:19 PDT
That change will be needed soon. One is a syntax error and one is not.
Alex Christensen
Comment 4 2016-09-23 15:34:56 PDT
http://trac.webkit.org/changeset/206334
Note You need to log in before you can comment on or make changes to this bug.