Bug 162514

Summary: [JSC] Allow fixedExecutableMemoryPoolSize to be set during build
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: JavaScriptCoreAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add macro
mark.lam: review+
Fix nits mark.lam: review+

Don Olmstead
Reported 2016-09-23 14:49:30 PDT
Currently the memory pool size is set based on the CPU. The x64 version uses a 1GB pool size by default which is very large value. This value should be able to be specified by the port to allow overriding of the defaults.
Attachments
Add macro (1.24 KB, patch)
2016-09-23 15:57 PDT, Don Olmstead 		mark.lam: review+
DetailsFormatted DiffDiff
Fix nits (1.24 KB, patch)
2016-09-23 16:33 PDT, Don Olmstead 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2016-09-23 15:57:53 PDT
Created attachment 289715 [details] Add macro This allows the size in MB to be specified by the port. In CMake you would use add_definitions(-DFIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB=<value>) within the Platform cmake file within JavaScriptCore. I'm open to changes to the name and also not sure if there should be any sort of static assert that ensures the validity of the value.
Mark Lam
Comment 2 2016-09-23 16:04:32 PDT
Comment on attachment 289715 [details] Add macro LGTM. Did you want this reviewed? If so, please set the patch r attributes to r?. If you don't have committer privileges and want the patch committed, please set the patch cq attribute to cq?.
Mark Lam
Comment 3 2016-09-23 16:10:09 PDT
Comment on attachment 289715 [details] Add macro View in context: https://bugs.webkit.org/attachment.cgi?id=289715&action=review r=me with suggestion. > Source/JavaScriptCore/jit/ExecutableAllocator.h:75 > +#if defined FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB nit: I prefer #ifdef FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB or # if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB)
Don Olmstead
Comment 4 2016-09-23 16:33:52 PDT
Created attachment 289719 [details] Fix nits Fixing nits
Konstantin Tokarev
Comment 5 2016-09-26 10:57:10 PDT
Comment on attachment 289719 [details] Fix nits View in context: https://bugs.webkit.org/attachment.cgi?id=289719&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.h:75 > +#ifdef FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB I'd preferred #if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB), it would be more in line with following #elif
Konstantin Tokarev
Comment 6 2016-09-26 11:12:12 PDT
Committed r206379: <http://trac.webkit.org/changeset/206379>
Note You need to log in before you can comment on or make changes to this bug.