Bug 162462
| Summary: | SlotVisitor::visitChildren() could be better at calling cell->visitChildren() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | keith_miller, mark.lam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Filip Pizlo
For starters, it shouldn't go looking for the VM every time.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Filip Pizlo
What if the right solution here is to JIT the SlotVisitor? That would be cool.
Filip Pizlo
(In reply to comment #1)
> What if the right solution here is to JIT the SlotVisitor? That would be
> cool.
BTW that's not insane. That's what Jikes RVM did: we had a specialized compiler for the visiting methods. It was a progression.
Filip Pizlo
But an even better solution would be to just make methodTable() not terrible.
Mark Lam
Sorry. Closed the wrong bug.