Bug 162420

Summary: Add a new runtime flag for work on modern media controls (off by default)
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: NEW    
Severity: Normal CC: commit-queue, dbates, eric.carlson, graouts, jeremyj-wk, jer.noble, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2016-09-22 10:57:23 PDT
Media controls on Apple platforms are going to have significant changes in the coming weeks. In order to land those gradually without negative impacts to usability and stability of existing media controls, we should add a new runtime flag to enable these "modern" media controls. This flag will be turned to be on by default at a later time as the code lands and becomes stable.
Attachments
Patch (20.41 KB, patch)
2016-09-22 11:03 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.36 KB, patch)
2016-09-23 00:59 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-22 10:58:35 PDT
<rdar://problem/28430201>
Antoine Quint
Comment 2 2016-09-22 11:03:00 PDT
Created attachment 289578 [details] Patch
WebKit Commit Bot
Comment 3 2016-09-22 11:06:10 PDT
Attachment 289578 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 4 2016-09-23 00:50:40 PDT
Comment on attachment 289578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289578&action=review > Source/WebCore/ChangeLog:9 > + No new tests (OOPS!). Oops!
Antoine Quint
Comment 5 2016-09-23 00:59:36 PDT
Created attachment 289669 [details] Patch for landing
Antoine Quint
Comment 6 2016-09-23 02:35:34 PDT
Comment on attachment 289669 [details] Patch for landing https://trac.webkit.org/changeset/206296
Note You need to log in before you can comment on or make changes to this bug.