Bug 162389 – CachedXSLStylesheet does not need to be updated according Origin/Fetch mode

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

No CORS check is done and loading is always same origin.

[youenn fablet]

Created attachment 289558 [details]
Patch

[Darin Adler]

Comment on attachment 289558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289558&action=review

> Source/WebCore/loader/cache/CachedResource.cpp:449
> +    ASSERT(type() != CachedResource::Type::FontResource || type() != CachedResource::Type::SVGFontResource);

This assertion will never fire; the expression will always be true. Please fix this by making this into two separate assertions.

[youenn fablet]

Created attachment 290898 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

> > Source/WebCore/loader/cache/CachedResource.cpp:449
> > +    ASSERT(type() != CachedResource::Type::FontResource || type() != CachedResource::Type::SVGFontResource);
> 
> This assertion will never fire; the expression will always be true. Please
> fix this by making this into two separate assertions.

Right, done.

[WebKit Commit Bot]

Comment on attachment 290898 [details]
Patch for landing

Clearing flags on attachment: 290898

Committed r206902: <http://trac.webkit.org/changeset/206902>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.