Bug 162386

Summary: Skip stress/string-joining-long-strings-should-not-crash.js on memory limited devices
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, ossy, ryanhaddad, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Csaba Osztrogonác
Reported 2016-09-22 06:19:11 PDT
stress/string-joining-long-strings-should-not-crash.js consumes at least 935Mb memory and then crashes on our JSCOnly bots. Let's skip it on memory limited devices.
Attachments
Patch (1.15 KB, patch)
2016-09-22 06:42 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.16 KB, patch)
2016-09-26 06:55 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-09-22 06:42:32 PDT
Created attachment 289555 [details] Patch
Csaba Osztrogonác
Comment 2 2016-09-22 06:47:07 PDT
Comment on attachment 289555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289555&action=review > JSTests/stress/string-joining-long-strings-should-not-crash.js:2 > -//@ runDefault > +//@largeHeap > +// @runDefault if !$memoryLimited We need this hack, because run-jsc-stress-tests processes all lines started with "//@".
Csaba Osztrogonác
Comment 3 2016-09-23 07:26:17 PDT
(In reply to comment #0) > stress/string-joining-long-strings-should-not-crash.js consumes > at least 935Mb memory and then crashes on our JSCOnly bots. > Let's skip it on memory limited devices. note: This test consumes 4.3Gb memory on X86_64
Mark Lam
Comment 4 2016-09-23 11:39:05 PDT
Comment on attachment 289555 [details] Patch r=me
WebKit Commit Bot
Comment 5 2016-09-23 12:02:34 PDT
Comment on attachment 289555 [details] Patch Clearing flags on attachment: 289555 Committed r206317: <http://trac.webkit.org/changeset/206317>
WebKit Commit Bot
Comment 6 2016-09-23 12:02:36 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 7 2016-09-23 14:03:59 PDT
Reverted r206317 for reason: This change caused timeouts on El Capitan Release JSC tests Committed r206330: <http://trac.webkit.org/changeset/206330>
Ryan Haddad
Comment 8 2016-09-23 14:04:51 PDT
*** Bug 162508 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 9 2016-09-26 06:49:51 PDT
(In reply to comment #7) > Reverted r206317 for reason: > > This change caused timeouts on El Capitan Release JSC tests > > Committed r206330: <http://trac.webkit.org/changeset/206330> Sorry for the trouble. It was a typo in my patch, I'll land the fixed patch.
Csaba Osztrogonác
Comment 10 2016-09-26 06:55:56 PDT
Created attachment 289825 [details] Patch for landing
WebKit Commit Bot
Comment 11 2016-09-26 07:29:14 PDT
Comment on attachment 289825 [details] Patch for landing Clearing flags on attachment: 289825 Committed r206374: <http://trac.webkit.org/changeset/206374>
WebKit Commit Bot
Comment 12 2016-09-26 07:29:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.