| Summary: | Fullscreen controls inoperative in WebKitLegacy web views | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, jeremyj-wk, jer.noble, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2016-09-21 21:13:20 PDT
Created attachment 289583 [details]
Patch
This is fine for a quick fix. But we should have a way to say "everything changed" In WebVideoFillscreenModelMediaElement, there is an event for "all". Either that, or something similar would be better than putting this inline. If we later add new properties, this would help make sure we don't miss this spot. (In reply to comment #3) > This is fine for a quick fix. But we should have a way to say "everything > changed" > > In WebVideoFillscreenModelMediaElement, there is an event for "all". Either > that, or something similar would be better than putting this inline. If we > later add new properties, this would help make sure we don't miss this spot. I was wondering the same thing about resetMediaState(); it resets the playerController to empty values, even if it still has a playbackSessionModel attached. Maybe in the future, resetMediaState() can retrieve all the cached values from the model if it exists, or set them to defaults if not. Comment on attachment 289583 [details] Patch Clearing flags on attachment: 289583 Committed r206272: <http://trac.webkit.org/changeset/206272> All reviewed patches have been landed. Closing bug. |