Bug 162344

Summary: URLParser: correctly parse relative URLs that are just one character
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Alex Christensen 2016-09-21 09:41:55 PDT
URLParser: correctly parse relative URLs that are just one character
Comment 1 Alex Christensen 2016-09-21 09:42:45 PDT
Created attachment 289461 [details]
Patch
Comment 2 Tim Horton 2016-09-21 10:59:44 PDT
Comment on attachment 289461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289461&action=review

> Source/WebCore/platform/URLParser.cpp:1001
> -                ++c;
> +                incrementIteratorSkippingTabAndNewLine<serialized>(c);

There's another additional behavior change here besides the single-character thing: the tab/new line skipping. Should you test that too?
Comment 3 Alex Christensen 2016-09-21 11:01:09 PDT
Comment on attachment 289461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289461&action=review

>> Source/WebCore/platform/URLParser.cpp:1001
>> +                incrementIteratorSkippingTabAndNewLine<serialized>(c);
> 
> There's another additional behavior change here besides the single-character thing: the tab/new line skipping. Should you test that too?

That is tested.  I added a test with \t\n after the one character.
Comment 4 Alex Christensen 2016-09-21 11:02:44 PDT
http://trac.webkit.org/changeset/206218