Bug 162344 - URLParser: correctly parse relative URLs that are just one character
Summary: URLParser: correctly parse relative URLs that are just one character
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-21 09:41 PDT by Alex Christensen
Modified: 2016-09-21 11:02 PDT (History)
0 users

See Also:

Attachments
Patch (3.40 KB, patch)
2016-09-21 09:42 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-21 09:41:55 PDT 
URLParser: correctly parse relative URLs that are just one character
Comment 1 Alex Christensen 2016-09-21 09:42:45 PDT 
Created attachment 289461 [details]
Patch
Comment 2 Tim Horton 2016-09-21 10:59:44 PDT 
Comment on attachment 289461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289461&action=review

> Source/WebCore/platform/URLParser.cpp:1001
> -                ++c;
> +                incrementIteratorSkippingTabAndNewLine<serialized>(c);

There's another additional behavior change here besides the single-character thing: the tab/new line skipping. Should you test that too?
Comment 3 Alex Christensen 2016-09-21 11:01:09 PDT 
Comment on attachment 289461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289461&action=review

>> Source/WebCore/platform/URLParser.cpp:1001
>> +                incrementIteratorSkippingTabAndNewLine<serialized>(c);
> 
> There's another additional behavior change here besides the single-character thing: the tab/new line skipping. Should you test that too?

That is tested.  I added a test with \t\n after the one character.
Comment 4 Alex Christensen 2016-09-21 11:02:44 PDT 
http://trac.webkit.org/changeset/206218