WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162344
URLParser: correctly parse relative URLs that are just one character
https://bugs.webkit.org/show_bug.cgi?id=162344
Summary
URLParser: correctly parse relative URLs that are just one character
Alex Christensen
Reported
2016-09-21 09:41:55 PDT
URLParser: correctly parse relative URLs that are just one character
Attachments
Patch
(3.40 KB, patch)
2016-09-21 09:42 PDT
,
Alex Christensen
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2016-09-21 09:42:45 PDT
Created
attachment 289461
[details]
Patch
Tim Horton
Comment 2
2016-09-21 10:59:44 PDT
Comment on
attachment 289461
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=289461&action=review
> Source/WebCore/platform/URLParser.cpp:1001 > - ++c; > + incrementIteratorSkippingTabAndNewLine<serialized>(c);
There's another additional behavior change here besides the single-character thing: the tab/new line skipping. Should you test that too?
Alex Christensen
Comment 3
2016-09-21 11:01:09 PDT
Comment on
attachment 289461
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=289461&action=review
>> Source/WebCore/platform/URLParser.cpp:1001 >> + incrementIteratorSkippingTabAndNewLine<serialized>(c); > > There's another additional behavior change here besides the single-character thing: the tab/new line skipping. Should you test that too?
That is tested. I added a test with \t\n after the one character.
Alex Christensen
Comment 4
2016-09-21 11:02:44 PDT
http://trac.webkit.org/changeset/206218
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug