Bug 162328

Summary: Fix enumeration of properties cross origin
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, barraclough, cdumez, commit-queue, ggaren, mark.lam, rniwa, saam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 162311    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2016-09-20 18:46:32 PDT
All cross origin properties for Window / Location are supposed to be not enumerable:
- https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)

Therefore, there should be no properties to iterate on for cross origin Window / Location objects.

W3C test:
- http://w3c-test.org/html/browsers/origin/cross-origin-objects/cross-origin-objects.html ([[Enumerate]] subtest)
Comment 1 Chris Dumez 2016-09-20 18:51:09 PDT
Created attachment 289423 [details]
Patch
Comment 2 Alex Christensen 2016-09-21 12:52:57 PDT
Comment on attachment 289423 [details]
Patch

Are both of the changes covered by the one test?
Comment 3 Chris Dumez 2016-09-21 12:53:58 PDT
(In reply to comment #2)
> Comment on attachment 289423 [details]
> Patch
> 
> Are both of the changes covered by the one test?

Yes, this test iterates both on Window and Location.
Comment 4 Chris Dumez 2016-09-21 13:49:15 PDT
Comment on attachment 289423 [details]
Patch

Clearing flags on attachment: 289423

Committed r206233: <http://trac.webkit.org/changeset/206233>
Comment 5 Chris Dumez 2016-09-21 13:49:21 PDT
All reviewed patches have been landed.  Closing bug.