Bug 162327

Summary: REGRESSION(r205692): Minified builds have broken inspector
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix mattbaker: review+

Joseph Pecoraro
Reported 2016-09-20 18:01:15 PDT
Summary: Minified builds have broken inspector http://trac.webkit.org/changeset/205692 Seems the JavaScriptCore cssmin.py was older then the WebInspector one we dropped. The jsmin.py files were equivalent. Bring back the proper cssmin.
Attachments
[PATCH] Proposed Fix (2.17 KB, patch)
2016-09-20 18:02 PDT, Joseph Pecoraro 		mattbaker: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-09-20 18:01:23 PDT
<rdar://problem/28370137>
Joseph Pecoraro
Comment 2 2016-09-20 18:02:45 PDT
Created attachment 289417 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2016-09-20 18:04:48 PDT
Attachment 289417 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/Scripts/cssmin.py:33: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 4 2016-09-20 18:05:56 PDT
<https://trac.webkit.org/changeset/206192>
Note You need to log in before you can comment on or make changes to this bug.