Bug 162324

Summary: FTL needs to reserve callee stack space in bytes
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2016-09-20 16:40:49 PDT
The FTL code to compile outgoing calls uses the B3 function, requestCallArgAreaSize(), to assure there is enough stack space to make the call. In one instance the call is made with a argument in bytes, while the other two instances use count of JSValue sized objects. Reading the code in B3 and Air shows that the value should be in bytes. Therefore those two instances are wrong.
Attachments
Patch (8.29 KB, patch)
2016-09-20 17:45 PDT, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2016-09-20 17:45:46 PDT
Created attachment 289414 [details] Patch
Geoffrey Garen
Comment 2 2016-09-20 20:20:19 PDT
Comment on attachment 289414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289414&action=review r=me > Source/JavaScriptCore/ChangeLog:14 > + No new tests as this doesn't surface as an issue when arguments are pass on the stack. passed
Michael Saboff
Comment 3 2016-09-21 09:28:26 PDT
Committed r206212: <http://trac.webkit.org/changeset/206212>
Note You need to log in before you can comment on or make changes to this bug.