Bug 162259

Summary: Adopt MRMediaRemoteSetParentApplication.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, eric.carlson, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
andersca: review+
Patch for landing none

Jer Noble
Reported 2016-09-19 23:59:07 PDT
Adopt MRMediaRemoteSetParentApplication.
Attachments
Patch (9.48 KB, patch)
2016-09-20 00:38 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (11.00 KB, patch)
2016-09-20 09:20 PDT, Jer Noble 		andersca: review+
DetailsFormatted DiffDiff
Patch for landing (12.26 KB, patch)
2016-09-20 17:02 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-09-20 00:37:18 PDT
<rdar://problem/28376161>
Jer Noble
Comment 2 2016-09-20 00:38:26 PDT
Created attachment 289334 [details] Patch
Sam Weinig
Comment 3 2016-09-20 01:48:22 PDT
Comment on attachment 289334 [details] Patch What is the ramification of passing a bad source application identifier here? If this is new SPI, should we pass the sourceApplicationAuditData instead, since that is verifiable?
Jer Noble
Comment 4 2016-09-20 09:20:28 PDT
Created attachment 289357 [details] Patch
Anders Carlsson
Comment 5 2016-09-20 10:55:45 PDT
Comment on attachment 289357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289357&action=review > Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:176 > + if (MRMediaRemoteSetParentApplication && !parentApplication.isEmpty()) Should this be canLoad_MRMediaRemoteSetParentApplication?
Jer Noble
Comment 6 2016-09-20 16:39:22 PDT
(In reply to comment #5) > Comment on attachment 289357 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289357&action=review > > > Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:176 > > + if (MRMediaRemoteSetParentApplication && !parentApplication.isEmpty()) > > Should this be canLoad_MRMediaRemoteSetParentApplication? Yep!
Jer Noble
Comment 7 2016-09-20 17:02:21 PDT
Created attachment 289411 [details] Patch for landing
WebKit Commit Bot
Comment 8 2016-09-20 18:12:32 PDT
Comment on attachment 289411 [details] Patch for landing Clearing flags on attachment: 289411 Committed r206193: <http://trac.webkit.org/changeset/206193>
Note You need to log in before you can comment on or make changes to this bug.