Bug 162253

Summary: [JSC] Add `typeof value === "symbol"` handling to bytecode compiler
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Yusuke Suzuki 2016-09-19 21:41:27 PDT 
We can easily implement it by using is_cell_with_type.
Comment 1 Yusuke Suzuki 2016-09-19 21:47:48 PDT 
Benefit is super tiny, but it is consistent to the current implementation that have the similar path for "string" case.
Comment 2 Yusuke Suzuki 2016-09-19 21:48:09 PDT 
                          baseline                  patched                                      

is-symbol              1.5291+-0.0149     ^      1.4763+-0.0160        ^ definitely 1.0358x faster
is-symbol-mixed        4.7242+-0.1301            4.5916+-0.1242          might be 1.0289x faster
Comment 3 Yusuke Suzuki 2016-09-19 21:50:17 PDT 
Created attachment 289310 [details]
Patch
Comment 4 Yusuke Suzuki 2016-09-20 08:24:40 PDT 
Comment on attachment 289310 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2016-09-20 08:47:56 PDT 
Comment on attachment 289310 [details]
Patch

Clearing flags on attachment: 289310

Committed r206147: <http://trac.webkit.org/changeset/206147>
Comment 6 WebKit Commit Bot 2016-09-20 08:48:00 PDT 
All reviewed patches have been landed.  Closing bug.