Bug 162250

Summary:

REGRESSION (r204552): Athlete search on Strava gives bad rendering.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews113 for mac-yosemite	none
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2	none
Patch	none
Patch	none
Patch	none

Description zalan 2016-09-19 20:13:24 PDT

1. Log into Strava
2. Be on your feed page: https://www.strava.com/dashboard
3. Click the magnifying glass
4. Start typing

Comment 1 zalan 2016-09-19 20:16:44 PDT

rdar://problem/28156433

Comment 2 zalan 2016-09-19 20:56:42 PDT

Created attachment 289308 [details]
Patch

Comment 3 Build Bot 2016-09-19 21:51:05 PDT

Comment on attachment 289308 [details]
Patch

Attachment 289308 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2109844

New failing tests:
compositing/layer-creation/overlap-transformed-layer.html
compositing/layer-creation/overlap-child-layer.html
compositing/layer-creation/fixed-position-under-transform.html
imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
imported/blink/compositing/child-transform-layer-rounding.html

Comment 4 Build Bot 2016-09-19 21:51:09 PDT

Created attachment 289311 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 5 Build Bot 2016-09-19 21:56:30 PDT

Comment on attachment 289308 [details]
Patch

Attachment 289308 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2109877

New failing tests:
compositing/layer-creation/overlap-transformed-layer.html
compositing/layer-creation/overlap-child-layer.html
compositing/layer-creation/fixed-position-under-transform.html
imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
imported/blink/compositing/child-transform-layer-rounding.html

Comment 6 Build Bot 2016-09-19 21:56:33 PDT

Created attachment 289312 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 7 Build Bot 2016-09-19 22:00:09 PDT

Comment on attachment 289308 [details]
Patch

Attachment 289308 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2109871

New failing tests:
compositing/layer-creation/overlap-transformed-layer.html
compositing/layer-creation/overlap-child-layer.html
compositing/layer-creation/fixed-position-under-transform.html
imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
imported/blink/compositing/child-transform-layer-rounding.html

Comment 8 Build Bot 2016-09-19 22:00:12 PDT

Created attachment 289314 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 9 Build Bot 2016-09-19 22:07:00 PDT

Comment on attachment 289308 [details]
Patch

Attachment 289308 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2109879

New failing tests:
compositing/layer-creation/overlap-transformed-layer.html
compositing/layer-creation/overlap-child-layer.html
compositing/layer-creation/fixed-position-under-transform.html
imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
imported/blink/compositing/child-transform-layer-rounding.html

Comment 10 Build Bot 2016-09-19 22:07:04 PDT

Created attachment 289317 [details]
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 11 zalan 2016-09-20 09:00:11 PDT

Created attachment 289354 [details]
Patch

Comment 12 zalan 2016-09-20 14:50:35 PDT

Created attachment 289400 [details]
Patch

Comment 13 Simon Fraser (smfr) 2016-09-20 15:08:27 PDT

Comment on attachment 289400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289400&action=review

> Source/WebCore/platform/graphics/LayoutRect.h:134
> +        float maxX = location.x() + size.width();
> +        float maxY = location.y() + size.height();

Use FloatRect::maxX()/maxY().

> Source/WebCore/platform/graphics/LayoutRect.h:150
> +    void checkedUnite(const LayoutRect&);

I think this should return a bool saying if it bailed.

Comment 14 zalan 2016-09-20 15:32:55 PDT

Created attachment 289405 [details]
Patch

Comment 15 WebKit Commit Bot 2016-09-20 17:27:21 PDT

Comment on attachment 289405 [details]
Patch

Clearing flags on attachment: 289405

Committed r206188: <http://trac.webkit.org/changeset/206188>

Comment 16 WebKit Commit Bot 2016-09-20 17:27:26 PDT

All reviewed patches have been landed.  Closing bug.