Bug 162239

Summary:

[WinCairo] Use find_package cairo in build

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Add find_package cairo	none
Add find_package cairo	none
With correct line endings	achristensen: review+, commit-queue: commit-queue-
Fix style issues	none

Don Olmstead

Reported 2016-09-19 14:27:49 PDT

WinCairo is currently manually appending the sources and libraries for Cairo. It should be using find_package(CAIRO) instead.

Attachments
Add find_package cairo (12.81 KB, patch) 2016-09-19 16:46 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Add find_package cairo (12.90 KB, patch) 2016-09-19 16:53 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
With correct line endings (6.25 KB, patch) 2016-09-19 17:00 PDT, Don Olmstead	achristensen: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Fix style issues (6.26 KB, patch) 2016-09-19 17:35 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2016-09-19 16:46:22 PDT

Created attachment 289281 [details] Add find_package cairo

Don Olmstead

Comment 2 2016-09-19 16:53:45 PDT

Created attachment 289283 [details] Add find_package cairo

Don Olmstead

Comment 3 2016-09-19 17:00:40 PDT

Created attachment 289285 [details] With correct line endings

Brent Fulgham

Comment 4 2016-09-19 17:02:23 PDT

Comment on attachment 289285 [details] With correct line endings Looks good. Let's get alex to look at it for final approval.

WebKit Commit Bot

Comment 5 2016-09-19 17:03:35 PDT

Attachment 289285 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 6 2016-09-19 17:04:17 PDT

Comment on attachment 289285 [details] With correct line endings Seems legit. If it breaks the WinCairo bot, we'll roll it out.

WebKit Commit Bot

Comment 7 2016-09-19 17:05:48 PDT

Comment on attachment 289285 [details] With correct line endings Rejecting attachment 289285 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 289285, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2108698

Don Olmstead

Comment 8 2016-09-19 17:35:29 PDT

Created attachment 289292 [details] Fix style issues

WebKit Commit Bot

Comment 9 2016-09-20 11:10:01 PDT

Comment on attachment 289292 [details] Fix style issues Clearing flags on attachment: 289292 Committed r206153: <http://trac.webkit.org/changeset/206153>

WebKit Commit Bot

Comment 10 2016-09-20 11:10:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.