Bug 162180

Summary: REGRESSION (r205275): LOG_WITH_STREAM() macros are all compiled in release builds now
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebCore Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Keith Rollin 2016-09-19 11:05:42 PDT 
After https://trac.webkit.org/changeset/205275, all LOG_WITH_STREAM macros are now enabled in release builds, because LogMacros.h has:

#if LOG_DISABLED && RELEASE_LOG_DISABLED
...
#else
#define LOG_WITH_STREAM(.....)
#endif

LOG() is OK, so we should make them match.

<rdar://problem/28347599>
Comment 1 Keith Rollin 2016-09-19 11:45:04 PDT 
Disable those macros in RELEASE_LOG_DISABLED mode. With that disabled, there were a couple of downstream effects. First, GraphicsContextCG.cpp would no longer access a local variable in release mode, so that variable needed to be conditionally defined. Second, the inclusion of logFunctionResult also needed to be fiddled with.
Comment 2 Keith Rollin 2016-09-19 13:44:49 PDT 
Created attachment 289253 [details]
Patch
Comment 3 WebKit Commit Bot 2016-09-19 15:01:41 PDT 
Comment on attachment 289253 [details]
Patch

Clearing flags on attachment: 289253

Committed r206120: <http://trac.webkit.org/changeset/206120>
Comment 4 WebKit Commit Bot 2016-09-19 15:01:45 PDT 
All reviewed patches have been landed.  Closing bug.