Summary: | [EFL] ewk_context_menu_item_select test have been failed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hunseop Jeong <hs85.jeong> | ||||||
Component: | WebKit EFL | Assignee: | Hunseop Jeong <hs85.jeong> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, gyuyoung.kim, lucas.de.marchi | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Hunseop Jeong
2016-09-19 01:35:45 PDT
Created attachment 289298 [details]
Patch
Comment on attachment 289298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289298&action=review LGTM with my comment. > Source/WebKit2/ChangeLog:9 > + to wait to finish the loading. I change the codes to finish the test when "testFinished" is true. It seems to me that this description is unclear to me. I revise it as below, ewk_context_menu_item_select has been waited until test page loading is finished, but it is unnecessary to wait the loading is finished. It would be good to pass if *testFinished* flag is true. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:200 > + ewkViewClass()->context_menu_hide = finishTest; Nice catch. We have missed to do it. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:205 > + testFinished = false; ditto. Created attachment 289413 [details]
Patch
(In reply to comment #2) > Comment on attachment 289298 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289298&action=review > > LGTM with my comment. > > > Source/WebKit2/ChangeLog:9 > > + to wait to finish the loading. I change the codes to finish the test when "testFinished" is true. > > It seems to me that this description is unclear to me. I revise it as below, > > ewk_context_menu_item_select has been waited until test page loading is > finished, but it is unnecessary > to wait the loading is finished. It would be good to pass if *testFinished* > flag is true. Thanks Gyuyoung, I will try to write down a clear description. Comment on attachment 289413 [details] Patch Clearing flags on attachment: 289413 Committed r206194: <http://trac.webkit.org/changeset/206194> All reviewed patches have been landed. Closing bug. |