Bug 162112

Summary:

Add a unit test covering <https://trac.webkit.org/changeset/205983>

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Tools / Tests

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, lforschler, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Refactored TestWKWebView to be hosted in a key window.	none
s/NSWindowStyleMaskBorderless/NSBorderlessWindowMask	none
Rewrote 2 disabled CandidateTests as WK2 tests	none

Wenson Hsieh

Reported 2016-09-16 21:05:23 PDT

Add a unit test covering https://bugs.webkit.org/show_bug.cgi?id=162008

Attachments
Patch (15.66 KB, patch) 2016-09-16 21:09 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Refactored TestWKWebView to be hosted in a key window. (22.48 KB, patch) 2016-09-17 11:23 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
s/NSWindowStyleMaskBorderless/NSBorderlessWindowMask (22.47 KB, patch) 2016-09-17 11:45 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Rewrote 2 disabled CandidateTests as WK2 tests (33.30 KB, patch) 2016-09-18 12:27 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2016-09-16 21:09:32 PDT

Created attachment 289158 [details] Patch

Tim Horton

Comment 2 2016-09-17 01:21:10 PDT

Comment on attachment 289158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289158&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:33 > +#import <AppKit/NSTouchDevice_Private.h> I don't think you can do that.

Wenson Hsieh

Comment 3 2016-09-17 11:21:26 PDT

Comment on attachment 289158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289158&action=review >> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:33 >> +#import <AppKit/NSTouchDevice_Private.h> > > I don't think you can do that. Indeed -- it seems I forgot to remove this after debugging. I'll upload a v2 (there are some other issues I addressed, such as +[CandidateTestWebView setUpWithFrame:] not actually using its params).

Wenson Hsieh

Comment 4 2016-09-17 11:23:34 PDT

Created attachment 289174 [details] Refactored TestWKWebView to be hosted in a key window.

Wenson Hsieh

Comment 5 2016-09-17 11:45:23 PDT

Created attachment 289176 [details] s/NSWindowStyleMaskBorderless/NSBorderlessWindowMask

Wenson Hsieh

Comment 6 2016-09-18 12:27:12 PDT

Created attachment 289210 [details] Rewrote 2 disabled CandidateTests as WK2 tests

Beth Dakin

Comment 7 2016-09-19 17:06:38 PDT

Comment on attachment 289210 [details] Rewrote 2 disabled CandidateTests as WK2 tests Looks good!

WebKit Commit Bot

Comment 8 2016-09-19 18:04:53 PDT

Comment on attachment 289210 [details] Rewrote 2 disabled CandidateTests as WK2 tests Clearing flags on attachment: 289210 Committed r206135: <http://trac.webkit.org/changeset/206135>

WebKit Commit Bot

Comment 9 2016-09-19 18:04:57 PDT

All reviewed patches have been landed. Closing bug.

Wenson Hsieh

Comment 10 2016-09-20 08:10:13 PDT

Reopening to attach new patch.

Wenson Hsieh

Comment 11 2016-09-22 09:14:10 PDT

I must have accidentally reopened this. Closing.

Note You need to log in before you can comment on or make changes to this bug.