Bug 162061

Summary: [GTK] Move the rendering of auth dialog shadow to the auth dialog widget
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161530    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2016-09-16 09:41:11 PDT
Instead of rendering the shadow in the web view, we can let the auth dialog do it. This fixes the rendering of the shadow in Wayland when using gdk_cairo_draw_from_gl().
Attachments
Patch (6.06 KB, patch)
2016-09-16 09:46 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-09-16 09:46:11 PDT
Created attachment 289065 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-16 09:48:20 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2016-09-16 10:28:24 PDT
Comment on attachment 289065 [details] Patch Wait for EWS
Carlos Garcia Campos
Comment 4 2016-09-17 01:36:39 PDT
Committed r206067: <http://trac.webkit.org/changeset/206067>
Note You need to log in before you can comment on or make changes to this bug.