Bug 162046

Summary: Window's pageXOffset / pageYOffset attributes should be replaceable
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, esprehn+autocc, ggaren, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-09-15 19:02:38 PDT
Window's pageXOffset / pageYOffset attributes should be replaceable as per: - https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface Firefox agrees with the specification.
Attachments
Patch (9.59 KB, patch)
2016-09-15 19:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.86 KB, patch)
2016-09-19 12:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-09-15 19:33:22 PDT
Created attachment 289028 [details] Patch
Darin Adler
Comment 2 2016-09-19 11:12:29 PDT
Comment on attachment 289028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289028&action=review Please fix the GTK build. WebKitDOMDOMWindow.cpp has calls to these functions. > Source/WebCore/page/DOMWindow.idl:98 > + // FIXME: The following attributes should be double. Now that we don’t have non-JavaScript bindings to consider, changing these to double should be an easier thing to do, in fact I’m not sure it will actually have any observable effect. What are we waiting for to make that change?
Chris Dumez
Comment 3 2016-09-19 12:23:59 PDT
Created attachment 289247 [details] Patch
WebKit Commit Bot
Comment 4 2016-09-19 13:38:00 PDT
Comment on attachment 289247 [details] Patch Clearing flags on attachment: 289247 Committed r206109: <http://trac.webkit.org/changeset/206109>
WebKit Commit Bot
Comment 5 2016-09-19 13:38:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.