Bug 162044 – Web Inspector: Add test coverage for all array utility functions

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

Summary;
Add test coverage for all array utility functions. The following lack tests:

Array.prototype.lastValue
Array.prototype.remove
Array.prototype.toggleIncludes
Array.prototype.insertAtIndex
Array.prototype.keySet

[Radar WebKit Bug Importer]

<rdar://problem/28330846>

[Matt Baker]

Created attachment 289024 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 289024 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=289024&action=review

r=me!

> LayoutTests/inspector/unit-tests/array-utilities.html:129
> +        test: () => {

Style: We've been simplifying the syntax here to method syntax.

    test() {

> LayoutTests/inspector/unit-tests/array-utilities.html:179
> +            let arr2 = [1, 2, 3];
> +            arr2.insertAtIndex("x", 0);
> +            InspectorTest.expectShallowEqual(arr2, ["x", 1, 2, 3], "insertAtIndex with index zero should insert at the beginning.");

I'd like a test that inserts in the middle (any index such that 0 < index < length): insertAtIndex("x", 2)

[Matt Baker]

Created attachment 289123 [details]
[Patch] For Landing

[WebKit Commit Bot]

Comment on attachment 289123 [details]
[Patch] For Landing

Rejecting attachment 289123 [details] from commit-queue.

New failing tests:
inspector/unit-tests/array-utilities.html
Full output: http://webkit-queues.webkit.org/results/2090758

[WebKit Commit Bot]

Created attachment 289136 [details]
Archive of layout-test-results from webkit-cq-01 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Matt Baker]

Created attachment 289209 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 289209 [details]
Patch

Clearing flags on attachment: 289209

Committed r206085: <http://trac.webkit.org/changeset/206085>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.